Conversation
88433bf to
557a856
Compare
ruyadorno
left a comment
There was a problem hiding this comment.
It would be nice to add more tests with a variety of single vs multiple funding sources tests:
- In
test/tap/utils.funding.jsit would be nice to stress it a bit more with cases such as duplicated urls within the same array, also varying between shorthand string vs object (with and without type), etc - In
test/tap/fund.jsit would be nice to add a fixture using multiple funding items.
557a856 to
06c5cfb
Compare
|
@ruyadorno updated! i also added tests for the "open URL" multiple sources case, and fixed a bug. (There's a possible issue with command arg parsing - |
ruyadorno
left a comment
There was a problem hiding this comment.
just one very small doc request but that can even be added by the release manager 👍 LGTM
agreed 👍 + the team has been very busy reworking the entire handling of configs, so the implementation might change a lot in npm@7 - not to say it will fix itself but just that it's not the best moment to play with that 😬 |
06c5cfb to
a764b5c
Compare
What / Why
Adds support for multiple funding sources in
package.json.References
See npm/rfcs#68