[6.x] Prevent opening set picker when max_sets limit has been reached#14290
Merged
jackmcdade merged 1 commit into6.xfrom Mar 18, 2026
Merged
[6.x] Prevent opening set picker when max_sets limit has been reached#14290jackmcdade merged 1 commit into6.xfrom
max_sets limit has been reached#14290jackmcdade merged 1 commit into6.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where users could bypass the Replicator's set limit by clicking on a hidden clickable area between sets.
This was happening because the SetPicker's modal and popover triggers remained interactive even when the
enabledprop wasfalse. While the visible buttons were conditionally hidden, the underlying trigger slots were still capturing clicks and opening the picker.This PR fixes it by wrapping the trigger slots in a
Primitivecomponent with a capture-phase click handler that stops event propagation whenenabledisfalse, preventing the modal/popover from opening.Fixes #14285