Merged
Conversation
…cope Frontend Localize sets the translator only; align the test with app()->getLocale() staying the default while PHP LC_TIME and translator follow the site. Made-with: Cursor
Contributor
|
This works perfectly for me @jasonvarga |
jasonvarga
added a commit
that referenced
this pull request
Mar 25, 2026
This reverts commit 75a502a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the localize middleware to update the locale of the translator directly rather than as a side-effect of updating the entire app locale.
Setting the entire app locale had side effects of its own, including altering behavior of certain Carbon features like
startOfWeek().