feat(sdk-testing): Add W3CBaggagePropagator to test utils#7056
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Feb 7, 2025
Merged
Conversation
|
|
edeweerd1A
force-pushed
the
propagate-baggage-sdk-testing
branch
from
279790b to
2e42de1
Compare
Indeed the OpenTelemetryExtension and OpenTelemetryRule are injecting the W3CTraceContextPropagator but not the W3CBaggagePropagator. And the choice is not give in the API to change it after construction. So adding the baggage propagation right from the start. Hope this is OK.
edeweerd1A
force-pushed
the
propagate-baggage-sdk-testing
branch
from
2e42de1 to
b43d1ea
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7056 +/- ##
=========================================
Coverage 89.95% 89.96%
- Complexity 6668 6669 +1
=========================================
Files 748 748
Lines 20105 20113 +8
Branches 1970 1970
=========================================
+ Hits 18085 18094 +9
Misses 1427 1427
+ Partials 593 592 -1 ☔ View full report in Codecov by Sentry. |
jack-berg
approved these changes
Feb 7, 2025
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Given that baggage and tracecontext represent the default propagator configuration, this makes sense to me.
Maybe one day we'll want to support more customization options for the OpenTelemetry instance which is installed, but we can cross that bridge when we get there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indeed the OpenTelemetryExtension and OpenTelemetryRule are injecting the W3CTraceContextPropagator but not the W3CBaggagePropagator. And the choice is not give in the API to change it after construction.
So adding the baggage propagation right from the start.
Hope this is OK.