📝 Add requested permissions#492
Merged
luketomlinson merged 9 commits intoactions:mainfrom Jun 14, 2021
Merged
Conversation
C0ZEN
reviewed
Jun 7, 2021
Contributor
There was a problem hiding this comment.
I know it cannot be fun at all to do, but I think we should not present this as the required permissions and instead present this as the recommanded ones.
Then for each option, just below the default value, mention if this will require a specific permission(s).
It gives transparency and also security insights.
C0ZEN
reviewed
Jun 7, 2021
Contributor
C0ZEN
left a comment
C0ZEN
left a comment
There was a problem hiding this comment.
Lastly, I think it's worth suggesting a version with all the possible permissions so that if people don't care about security and wish to don't bother with this they still can (better than saying: enable everything mate!).
Co-authored-by: Geoffrey Testelin <geoffrey.testelin@gmail.com>
C0ZEN
reviewed
Jun 7, 2021
C0ZEN
reviewed
Jun 8, 2021
C0ZEN
reviewed
Jun 8, 2021
Co-authored-by: Geoffrey Testelin <geoffrey.testelin@gmail.com>
Contributor
Author
|
|
luketomlinson
approved these changes
Jun 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Context
Everybody knows which permissions are required for the action.
closes #491