Swizzle XCTestObservationCenter observer registration methods#278
Merged
phatblat merged 1 commit intoQuick:masterfrom Apr 7, 2016
Merged
Swizzle XCTestObservationCenter observer registration methods#278phatblat merged 1 commit intoQuick:masterfrom
phatblat merged 1 commit intoQuick:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #273, this approach uses swizzling of the private
_addLegacyTestObserver:method to registerCurrentTestCaseTracker, ensuring thatXCTestLoghas been registered first. The approach in #271 appeared to work for the typical use case, but Quick's test suite still had failing tests due to something not working right with these observers. This approach seems to work for all these cases.Addresses Quick/Quick#494. Redo of #271. May address #276. Hope to unblock Quick/Quick#507.