Skip to content

Experiment with TOC in solr#9898

Closed
cdrini wants to merge 7 commits intointernetarchive:masterfrom
cdrini:feature/toc-solr2
Closed

Experiment with TOC in solr#9898
cdrini wants to merge 7 commits intointernetarchive:masterfrom
cdrini:feature/toc-solr2

Conversation

@cdrini
Copy link
Copy Markdown
Collaborator

@cdrini cdrini commented Sep 20, 2024

Closes #

Technical

  • Add a new chapter field to solr and populate it on the edition level with the toc data in markdown format
  • On the work level, set it to the unsorted set of all its editions chapters.
  • RISK: This is a lot of new data in solr, and duplicated! Could cause bloat/perf issues
  • RISK: We use the work-level highlighting to display the toc in the search view, but we don't know which book the toc entry came from... Might need to include some edition data in there.
  • Add ability to see matching subjects to search page
  • Add ability to see matching chapters to search page
  • Special deploy: Need to add the new chapters field to solr. This can be done via the solr UI. Note this of course won't backfill the data, a full reindex is needed for that, but that will make it possible to merge/deploy this without needing the solr_next flag.

Testing

Screenshot

Stakeholders

@cdrini cdrini added Needs: Special Deploy This PR will need a non-standard deploy to production On testing.openlibrary.org labels Sep 23, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.14%. Comparing base (2e231fa) to head (260bb72).
Report is 488 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9898      +/-   ##
==========================================
- Coverage   17.27%   17.14%   -0.14%     
==========================================
  Files          87       91       +4     
  Lines        4845     4982     +137     
  Branches      860      867       +7     
==========================================
+ Hits          837      854      +17     
- Misses       3477     3589     +112     
- Partials      531      539       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cdrini cdrini force-pushed the feature/toc-solr2 branch from 3229519 to 4a1f7bb Compare June 5, 2025 01:03
@cdrini
Copy link
Copy Markdown
Collaborator Author

cdrini commented Oct 20, 2025

Closing in favour of #11366 and #11369

@cdrini cdrini closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Special Deploy This PR will need a non-standard deploy to production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants