This repository was archived by the owner on Apr 17, 2025. It is now read-only.
refactor(commands): move util function to toolbox#416
Closed
hinell wants to merge 1 commit intomrjones2014:masterfrom
Closed
refactor(commands): move util function to toolbox#416hinell wants to merge 1 commit intomrjones2014:masterfrom
hinell wants to merge 1 commit intomrjones2014:masterfrom
Conversation
Owner
|
What's the purpose of this PR? |
Contributor
Author
|
@mrjones2014 Refactoring. That function might be used elsewhere, so it's logical to keep it in tool box. |
Owner
But it isn't currently. We can move it if/when it's needed. |
Owner
|
Toolbox is supposed to be more for end-user utilities, this is an internal parser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I actually wanted to include this patch into #415 PR, but decided to go separately.
How to Test
N/A
Testing for Regressions
I have tested the following:
legendary.nvimin all modes (normal, insert, visual)legendary.nvim, then triggering via the keymap in all modes (normal, insert, visual)legendary.nvimin all modes (normal, insert, visual)legendary.nvim, then running the command manually from the command lineaugroup/autocmds created throughlegendary.nvimwork correctly