This repository was archived by the owner on Apr 22, 2023. It is now read-only.
child-process: support sending dgram socket#4864
Closed
AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
Closed
child-process: support sending dgram socket#4864AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
AndreasMadsen wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
Author
|
Oh, did something stupid there made everything pass when running |
Member
Author
|
Works now :) |
child.send can send net servers and sockets. Now that we have support for dgram clusters this functionality should be extended to include dgram sockets.
Member
Author
|
@isaacs fixed it now. |
Member
Author
|
@isaacs this will land before v0.10, right? |
Member
|
No. (I kid. Landed in bdf7ac2, thanks.) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
child.sendcan send netserversandsockets. Now that we have support fordgramclusters this functionality should be extended to includedgramsockets.