Skip to content

src: introduce TimerWrap/TimerWrapHandle utility#34186

Closed
jasnell wants to merge 3 commits intonodejs:masterfrom
jasnell:timers-wrap
Closed

src: introduce TimerWrap/TimerWrapHandle utility#34186
jasnell wants to merge 3 commits intonodejs:masterfrom
jasnell:timers-wrap

Conversation

@jasnell
Copy link
Copy Markdown
Member

@jasnell jasnell commented Jul 3, 2020

Several places throughout src/* make use of uv_timer_t internally (inspector, perf, quic, etc). These duplicate code. This introduces a new utility class to consolidate code and make it easier overall to work with internal uv_timer_t instances.

First commit adds the utility, subsequent commits update systems that use it.

The quic specific commit cannot be backported to 14.x, the rest of the commits are backportable.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants