src: introduce TimerWrap/TimerWrapHandle utility#34186
Closed
jasnell wants to merge 3 commits intonodejs:masterfrom
Closed
src: introduce TimerWrap/TimerWrapHandle utility#34186jasnell wants to merge 3 commits intonodejs:masterfrom
jasnell wants to merge 3 commits intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several places throughout src/* make use of uv_timer_t internally (inspector, perf, quic, etc). These duplicate code. This introduces a new utility class to consolidate code and make it easier overall to work with internal uv_timer_t instances.
First commit adds the utility, subsequent commits update systems that use it.
The quic specific commit cannot be backported to 14.x, the rest of the commits are backportable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes