esm: remove CLI flag limitation to programmatic registration#48439
Closed
JakobJingleheimer wants to merge 13 commits intonodejs:mainfrom
Closed
esm: remove CLI flag limitation to programmatic registration#48439JakobJingleheimer wants to merge 13 commits intonodejs:mainfrom
JakobJingleheimer wants to merge 13 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #46826
We see 2 potential approaches here when we detect a user is trying to register a loader and the worker etc have not be set up:
DefaultModuleLoaderwith aCustomizedModuleLoaderModuleLoader::register())The first seems the simplest. However, it's currently facing an issue where
ModuleJobmaintains a reference to the loader that instantiated it; in option 1, that reference becomes stale. Further work to be done is to sever their direct connection.