Skip to content

benchmark: update iterations of benchmark/domain/domain-fn-args.js#51408

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
lucshi:benchmark/domain/domain-fn-args.js
Mar 4, 2024
Merged

benchmark: update iterations of benchmark/domain/domain-fn-args.js#51408
nodejs-github-bot merged 2 commits intonodejs:mainfrom
lucshi:benchmark/domain/domain-fn-args.js

Conversation

@lucshi
Copy link
Copy Markdown

@lucshi lucshi commented Jan 9, 2024

Fixes: #50571

Found 40% regression on node20 compared with older version:
benchmark@benchmark-S2600WFT:
/luc/node_new$ /home/benchmark/.nvm/versions/node/v16.20.2/bin/node benchmark/domain/domain-fn-args.js
domain/domain-fn-args.js n=10 args=0: 59,126.81519322643
domain/domain-fn-args.js n=10 args=1: 55,949.690038717185
domain/domain-fn-args.js n=10 args=2: 49,182.34353866962
domain/domain-fn-args.js n=10 args=3: 58,395.18356525954

benchmark@benchmark-S2600WFT:~/luc/node_new$ /home/benchmark/.nvm/versions/node/v20.11.1/bin/node benchmark/domain/domain-fn-args.js
domain/domain-fn-args.js n=10 args=0: 38,578.609704063485
domain/domain-fn-args.js n=10 args=1: 38,735.66780291292
domain/domain-fn-args.js n=10 args=2: 39,472.645456698505
domain/domain-fn-args.js n=10 args=3: 39,021.49694266571

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmark Issues and PRs related to the benchmark subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. domain Issues and PRs related to the domain subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The performance gap between node16 and node21 changes as the n of the benchmark changes

4 participants