test: skip in test-buffer-tostring-rangeerror on allocation failure#58415
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 23, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the buffer allocation fails due to insufficient memory, there is no point continue testing toString().
#58142 is not sufficient to skip the test because
require('os').totalmem()> 1.75GB is not sufficient to safe guard from allocation failure. It's better to directly skip on a case-by-case basis.