Skip to content

tools: fix return value of try_check_compiler#59434

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
theanarkh:fix_try_check_compiler
Aug 13, 2025
Merged

tools: fix return value of try_check_compiler#59434
nodejs-github-bot merged 1 commit intonodejs:mainfrom
theanarkh:fix_try_check_compiler

Conversation

@theanarkh
Copy link
Copy Markdown
Contributor

configure.py throws an error in Python 3.12.3.

Traceback (most recent call last):
  File "/home/ubuntu/node/./configure", line 27, in <module>
    import configure
  File "/home/ubuntu/node/configure.py", line 2328, in <module>
    check_compiler(output)
  File "/home/ubuntu/node/configure.py", line 1297, in check_compiler
    ok, is_clang, clang_version, gcc_version, is_apple = try_check_compiler(CXX, 'c++')
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: not enough values to unpack (expected 5, got 4)
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants