[v24.x] lib: do not modify prototype deprecated asyncResource (encore)#59518
Closed
slagiewka wants to merge 1 commit intonodejs:v24.x-stagingfrom
Closed
[v24.x] lib: do not modify prototype deprecated asyncResource (encore)#59518slagiewka wants to merge 1 commit intonodejs:v24.x-stagingfrom
slagiewka wants to merge 1 commit intonodejs:v24.x-stagingfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous attempt has missed one argument (
useEmitSync), therefore it effectively did not work as intended.This change sets
useEmitSynctofalsewhich is equivalent to previous behaviour ofundefinedand setsmodifyPrototypetofalseas expected.Refs: #58218
Refs: #59195