Skip to content

fix: minor tweaks to lib/unpublish.js#2304

Merged
isaacs merged 1 commit intonpm:release/v7.1.1from
ruyadorno:refactor-unpublish-tests
Dec 8, 2020
Merged

fix: minor tweaks to lib/unpublish.js#2304
isaacs merged 1 commit intonpm:release/v7.1.1from
ruyadorno:refactor-unpublish-tests

Conversation

@ruyadorno
Copy link
Copy Markdown
Contributor

  • Fix handling missing files error on reading package.json
  • Fixes autocompletion
  • Fixes printing name and version when using no args
  • Adds test/lib/unpublish.js tests

Fixes: npm/statusboard#180

@ruyadorno ruyadorno added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release labels Dec 8, 2020
@ruyadorno ruyadorno added this to the OSS - Sprint 21 milestone Dec 8, 2020
@ruyadorno ruyadorno self-assigned this Dec 8, 2020
@ruyadorno ruyadorno requested a review from a team as a code owner December 8, 2020 22:50
@ruyadorno ruyadorno force-pushed the refactor-unpublish-tests branch from 3d6dfba to e9a4f45 Compare December 8, 2020 22:54
- Fix handling missing files error on reading package.json
- Fixes autocompletion
- Fixes printing name and version when using no args
- Adds `test/lib/unpublish.js` tests

Fixes: npm/statusboard#180

PR-URL: npm#2304
Credit: @ruyadorno
Close: npm#2304
Reviewed-by: @isaacs
@isaacs isaacs changed the base branch from latest to release/v7.1.1 December 8, 2020 23:58
@isaacs isaacs force-pushed the refactor-unpublish-tests branch from e9a4f45 to b7d74b6 Compare December 8, 2020 23:59
@isaacs isaacs merged commit b7d74b6 into npm:release/v7.1.1 Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v7(tests): unpublish

2 participants