Test Unix{Datagram,Stream}::{set_}passcred() on Android#122324
Closed
dtolnay wants to merge 2 commits intorust-lang:masterfrom
Closed
Test Unix{Datagram,Stream}::{set_}passcred() on Android#122324dtolnay wants to merge 2 commits intorust-lang:masterfrom
Unix{Datagram,Stream}::{set_}passcred() on Android#122324dtolnay wants to merge 2 commits intorust-lang:masterfrom
Conversation
These methods are the pre-stabilized API for obtaining peer credentials
from an `AF_UNIX` socket, part of the `unix_socket_ancillary_data` feature.
Their current behavior is to get/set one of the `SO_PASSCRED` (Linux),
`LOCAL_CREDS_PERSISTENT` (FreeBSD), or `LOCAL_CREDS` (NetBSD) socket
options. On other targets the `{set_}passcred()` methods do not exist.
There are two problems with this approach:
1. Having public methods only exist for certain targets isn't permitted
in a stable `std` API.
2. These options have generally similar purposes, but they are non-POSIX
and their details can differ in subtle and surprising ways (such as
whether they continue to be set after the next call to `recvmsg()`).
Splitting into OS-specific extension traits is the preferred solution to
both problems.
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
dtolnay
force-pushed
the
os-unix-socket-ext
branch
from
3298004 to
ed48ec0
Compare
dtolnay
removed
A-testsuite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #117156 (comment) — this PR contains #117156 + a change in src/ci/github-actions/ci.yml to make it run the arm-android build, which is the one that failed in #121887 (comment).
r? ghost