Add FileCheck annotations to retag mir-opt test#150479
Open
AprilNEA wants to merge 4 commits intorust-lang:mainfrom
Open
Add FileCheck annotations to retag mir-opt test#150479AprilNEA wants to merge 4 commits intorust-lang:mainfrom
AprilNEA wants to merge 4 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
- Add CHECK for closure (main::{closure#0})
- Use CHECK-NEXT to verify Retag statements order after bb0
- Verify Retag for both self (_1) and reference parameters (_2)
rustbot
added
S-waiting-on-review
Collaborator
|
cjgillot
reviewed
Jan 7, 2026
| // CHECK: bb0: { | ||
| // CHECK-NEXT: Retag([fn entry] _1); | ||
| // CHECK-NEXT: Retag([fn entry] _2); | ||
| // CHECK: Retag(_0); |
Contributor
There was a problem hiding this comment.
We are checking that we retag just after assigning to _0.
Suggested change
| // CHECK: Retag(_0); | |
| // CHECK: _0 = {{.*}}; | |
| // CHECK-NEXT: Retag(_0); |
| // EMIT_MIR retag.main-{closure#0}.SimplifyCfg-pre-optimizations.after.mir | ||
| pub fn main() { | ||
| // CHECK-LABEL: fn main( | ||
| // CHECK: Retag(_{{[0-9]+}}); |
Contributor
There was a problem hiding this comment.
Could you elaborate a bit? There should be 7 retags in this function.
| // CHECK-LABEL: fn main::{closure#0}( | ||
| // CHECK: bb0: { | ||
| // CHECK-NEXT: Retag([fn entry] _1); | ||
| // CHECK-NEXT: Retag([fn entry] _2); |
| /// Casting directly to an array should also go through `&raw` and thus add appropriate retags. | ||
| // EMIT_MIR retag.array_casts.SimplifyCfg-pre-optimizations.after.mir | ||
| // CHECK-LABEL: fn array_casts( | ||
| // CHECK: Retag( |
Contributor
There was a problem hiding this comment.
Could you elaborate? There are 4 retags in this function.
cjgillot
added
S-waiting-on-author
Member
|
@AprilNEA any updates on this? thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #116971.
Add FileCheck annotations to
tests/mir-opt/retag.rs, removing the// skip-filecheckdirective.The added CHECK directives verify that the
AddRetagpass correctly insertsRetagstatements:selfand reference parameters (Retag([fn entry] _1),Retag([fn entry] _2))CHECK-NEXTto verify Retag statements appear immediately afterbb0: {Retag(_0))main::{closure#0}) with proper entry retagsarray_castsfunction (testing retags through&raw)box_to_raw_mutfunction with[raw]retag (Retag([raw] _0))r? @cjgillot