Some small nits for supertrait_item_shadowing, and additional testing#155172
Open
jackh726 wants to merge 1 commit intorust-lang:mainfrom
Open
Some small nits for supertrait_item_shadowing, and additional testing#155172jackh726 wants to merge 1 commit intorust-lang:mainfrom
jackh726 wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
jackh726
commented
Apr 11, 2026
Comment on lines
+26
to
+27
| //[off_normal,off_shadowing]~^ WARN a method with this name may be added | ||
| //[off_normal,off_shadowing]~| WARN once this associated item is added |
Member
Author
There was a problem hiding this comment.
So, looking at this, we may want to not lint when shadowing is enabled. Though, maybe we do, because behavior will change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #89151
r? types