compiletest: add a new diff for compare-out-by-lines tests.#155238
Open
Ozzy1423 wants to merge 1 commit intorust-lang:mainfrom
Open
compiletest: add a new diff for compare-out-by-lines tests.#155238Ozzy1423 wants to merge 1 commit intorust-lang:mainfrom
Ozzy1423 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Previously, when comparing output by lines, only the actual diff was shown. This is unhelpful since we expect lines to be shuffled around. With this new print, we can see the exact lines that are missing or have appeared without the noise of the moved around lines.
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when comparing output by lines, only the actual diff was shown. This is unhelpful since we expect lines to be shuffled around.
With this new print, we can see the exact lines that are missing or have appeared without the noise of the moved around lines.
Example, in this case a note has moved slightly so there is one more separator line "|":
r? @jieyouxu
cc @zetanumbers @ywxt