INI directive 'magic_quotes_sybase' is deprecated from PHP 5.3 and forbidden from PHP 5.4.

[octalmage]

I got the above error for the following line:

$sybase = ini_get('magic_quotes_sybase');

This seems like it should be alright since they're just checking the value using ini_get.

[octalmage]

From what I can tell, neither ini_set or ini_get throw an error when you call a deprecated config. So maybe we should just make these warnings? I've seen ini_get used for backwards compatible code.

[MarkMaldaba]

Setting a removed ini setting to a value that doesn't reflect the current state is likely to break many things (e.g. setting magic_quotes_sybase to true implies that your code is expecting data in a different format to what it will actually get). Therefore I think a warning should still be generated for ini_set().

Possibly we could add some intelligence so that ini_set('magic_quotes_sybase', false); doesn't throw an error but I'm not sure what the implications of that would be (it would be impossible to implement fully, e.g. where there are variables or expressions used to generate the new value, but maybe a naive implementation that just checked for literal false would be of some benefit).

But I can't see any situation where ini_get() would cause an issue even for a removed setting. Can anyone else think of one? If not then perhaps this check should be removed from the sniff for all settings.

[octalmage]

For sure, I totally agree that warnings should be reported for this. The problem is that errors are currently reported, and this would mean that code is not compatible. But in most situations I've seen this isn't the case.

In every situation I've seen with ini_get it was to manage workarounds, if safe_mode was enabled for example.