gfx/webrender_bindings/src/moz2d_renderer.rs
310	Maybe `pub fn new(buf: &'a [u8]) -> Self {` instead?
servo/ports/geckolib/glue.rs
6376	Same, `-> Self` should work and hopefully not trigger the warning?

nicolas.guichard updated this revision to Diff 911166.Sep 9 2024, 3:26 PM

Harbormaster completed remote builds in B699853: Diff 911166.Sep 9 2024, 3:26 PM

nicolas.guichard marked 2 inline comments as done.Sep 9 2024, 3:28 PM

nicolas.guichard added inline comments.

servo/ports/geckolib/glue.rs
6376	Yes, that's better indeed.

Please file a separate bug for this and move it there.

This revision now requires changes to proceed.Sep 10 2024, 12:30 AM

glandium removed a child revision: D221463: Bug 1917744 - Adjust mozglue build script for rustc 1.83. r=glandium!.Sep 10 2024, 3:33 AM

glandium added a parent revision: D221463: Bug 1917744 - Adjust mozglue build script for rustc 1.83. r=glandium!.

glandium added a child revision: D221464: Bug 1846041 - Allow unreachable_patterns for TryInto with platform-dependant types. r=glandium!.

glandium retitled this revision from Bug 1846041 - Fix Rust Nightly's new elided_named_lifetimes warning. r=glandium! to Bug 1917746 - Fix Rust 1.82's new elided_named_lifetimes warning. r=glandium!.Sep 10 2024, 3:38 AM

glandium removed a reviewer: glandium.

glandium changed the Bugzilla Bug ID from 1846041 to 1917746.

This revision is now accepted and ready to land.Sep 10 2024, 3:38 AM

Closed by commit rMOZILLACENTRAL22a83ceba50b: Bug 1917746 - Fix Rust 1.82's new elided_named_lifetimes warning. r=emilio (authored by nicolas.guichard). · Explain WhySep 10 2024, 4:59 AM

This revision was automatically updated to reflect the committed changes.

nicolas.guichard marked an inline comment as done.

nicolas.guichard added a commit: rMOZILLACENTRAL22a83ceba50b: Bug 1917746 - Fix Rust 1.82's new elided_named_lifetimes warning. r=emilio.

nicolas.guichard mentioned this in D221464: Bug 1846041 - Allow unreachable_patterns for TryInto with platform-dependant types. r=glandium!.Sep 10 2024, 1:59 PM