fix test (#233)

* fix test

* ah a few more to fix

Author: boshek

tests/testthat/test-historical-webservice.R

@@ -21,10 +21,11 @@ httptest2::with_mock_dir("fixtures", {
 
 
   test_that("ws_daily_flows is empty with a nearish date", {
+    # using a fixed date that was empty on the date of fixture creation
     expect_error(ws_daily_flows(
       station_number = "08MF005",
-      start_date = Sys.Date() - 2,
-      end_date = Sys.Date()
+      start_date = as.Date("2025-10-27"),
+      end_date = as.Date("2025-10-29")
     ), "No data exists for this station query during the period chosen")
   })
 
@@ -46,10 +47,11 @@ httptest2::with_mock_dir("fixtures", {
 
 
   test_that("ws_daily_levels is empty with a nearish date", {
+    # using a fixed date that was empty on the date of fixture creation
     expect_error(ws_daily_levels(
       station_number = "08MF005",
-      start_date = Sys.Date() - 2,
-      end_date = Sys.Date()
+      start_date = as.Date("2025-10-27"),
+      end_date = as.Date("2025-10-29")
     ), "No data exists for this station query during the period chosen")
   })
 })

tests/testthat/test-realtime-webservice.R

@@ -6,8 +6,8 @@ httptest2::with_mock_dir("fixtures", {
     ws_test <- realtime_ws(
       station_number = "08MF005",
       parameters = c(46), ## Water level
-      start_date = Sys.Date() - 7,
-      end_date = Sys.Date() - 7
+      start_date = as.Date("2025-10-22"),
+      end_date = as.Date("2025-10-22")
     )
 
     expect_identical(
@@ -36,8 +36,8 @@ httptest2::with_mock_dir("fixtures", {
     output <- realtime_ws(
       station_number = "08MF005",
       parameters = 46,
-      start_date = Sys.Date() - 8,
-      end_date = Sys.Date() - 7
+      start_date = as.Date("2025-10-21"),
+      end_date = as.Date("2025-10-22")
     )
 
     expect_s3_class(output, "tbl_df")
@@ -68,8 +68,8 @@ test_that("realtime_ws handles Date objects", {
     output <- realtime_ws(
       station_number = "08MF005",
       parameters = 46,
-      start_date = Sys.Date() - 8,
-      end_date = Sys.Date() - 7
+      start_date = as.Date("2025-10-21"),
+      end_date = as.Date("2025-10-22")
     )
 
     expect_s3_class(output, "tbl_df")

tests/testthat/test-webservice-classes.R

@@ -166,8 +166,8 @@ httptest2::with_mock_dir("fixtures", {
     result <- realtime_ws(
       station_number = "08MF005",
       parameters = 46,
-      start_date = Sys.Date() - 7,
-      end_date = Sys.Date() - 7
+      start_date = as.Date("2025-10-22"),
+      end_date = as.Date("2025-10-22")
     )
 
     expect_s3_class(result, "ws")