Merge pull request #231 from ropensci/b-ggplot-deprec

B ggplot deprec

Author: christophsax

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: tsbox
 Type: Package
 Title: Class-Agnostic Time Series
-Version: 0.4.1.9002
+Version: 0.4.2
 Authors@R: c(
     person("Christoph", "Sax", email = "[email protected]", role = c("aut", "cre"), comment = c(ORCID = "0000-0002-7192-7044")),
     person("Cathy", "Chamberlin", role = c("rev")),
@@ -43,7 +43,7 @@ Encoding: UTF-8
 URL: https://docs.ropensci.org/tsbox/, https://github.com/ropensci/tsbox
 BugReports: https://github.com/ropensci/tsbox/issues
 Roxygen: list(markdown = TRUE, roclets = c ("namespace", "rd", "srr::srr_stats_roclet"))
-RoxygenNote: 7.2.3
+RoxygenNote: 7.3.2
 VignetteBuilder: knitr
 Depends: 
     R (>= 2.10)

NEWS.md

@@ -1,6 +1,10 @@
-# tsbox 0.4.1.9001
+# tsbox 0.4.2
+
+## Bug fixes
 
 - ts_ggplot: pass symbols, not strings (fix #223)
+- scale_color_tsbox / scale_fill_tsbox: deprecated ds argument
+- dectime_to_POSIXct(): fix calc and rounding of seconds (#228) Thanks Miguel!
 
 
 # tsbox 0.4.1  (2023-05-06)

R/ts_ggplot.R

@@ -176,9 +176,8 @@ colors_tsbox <- function() {
 scale_color_tsbox <- function(...) {
   stopifnot(requireNamespace("ggplot2"))
   ggplot2::discrete_scale(
-    "colour",
-    "ds",
-    scales::manual_pal(colors_tsbox()),
+    aesthetics = "colour",
+    palette = scales::manual_pal(colors_tsbox()),
     ...
   )
 }
@@ -188,9 +187,8 @@ scale_color_tsbox <- function(...) {
 scale_fill_tsbox <- function(...) {
   stopifnot(requireNamespace("ggplot2"))
   ggplot2::discrete_scale(
-    "fill",
-    "ds",
-    scales::manual_pal(colors_tsbox()),
+    aesthetics = "fill",
+    palette = scales::manual_pal(colors_tsbox()),
     ...
   )
 }

README.Rmd

@@ -116,6 +116,4 @@ ts_plot(ts_scale(ts_c(mdeaths, austres, AirPassengers, DAX = EuStockMarkets[ ,'D
 
 ### Cheatsheet
 
-<a href="https://www.cynkra.com/blog/2019-04-10-tsbox-01/tsbox-cheatsheet.pdf"><img style="max-width:50%;" src="https://www.cynkra.com/blog/2019-04-10-tsbox-01/tsbox-cheatsheet-small.jpg"></a>
-
-
+<a href="https://blog.cynkra.com/posts/2019-04-10-tsbox-01/tsbox-cheatsheet.pdf"><img style="max-width:50%;" src="https://blog.cynkra.com/posts/2019-04-10-tsbox-01/tsbox-cheatsheet-small.jpg"></a>

README.md

@@ -108,4 +108,4 @@ be. And we finally get a legend!
 
 ### Cheatsheet
 
-<a href="https://www.cynkra.com/blog/2019-04-10-tsbox-01/tsbox-cheatsheet.pdf"><img style="max-width:50%;" src="https://www.cynkra.com/blog/2019-04-10-tsbox-01/tsbox-cheatsheet-small.jpg"></a>
+<a href="https://blog.cynkra.com/posts/2019-04-10-tsbox-01/tsbox-cheatsheet.pdf"><img style="max-width:50%;" src="https://blog.cynkra.com/posts/2019-04-10-tsbox-01/tsbox-cheatsheet-small.jpg"></a>