-
Notifications
You must be signed in to change notification settings - Fork 98
FedCM Object Token Enhancement #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hlflanagan @wseltzer should we have a discussion about this proposal? Has it already happened at a meeting I missed? |
npm1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Added some other comments besides what Christian mentioned. I still think this needs some work, mainly in simplifying it and making it more correct to what we want.
This was last discussed here https://github.com/w3c-fedid/meetings/blob/main/2025/2025-07-29-FedCM-notes.md |
| </div> | ||
|
|
||
| <!-- ============================================================ --> | ||
| ### Token Content Privacy ### {#token-content-privacy} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this section adds much value
npm1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned, you need to modify some other algorithms. For example, the 'show a continuation dialog' says it returns a (string, string?). And 'resolve' needs to allow passing an arbitary token too, not just a string
npm1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change resolve too? It shows as DOMString token still.
SHA: 843eb51 Reason: push, by npm1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 843eb51 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This change extends the FedCM API to allow IdPs to return structured objects directly as tokens.
Preview | Diff