fix: Metrics Export Error log (#2425)

* fix: Metrics Export Error log

* fix: Metrics Export Error log

* fix: Metrics Export Error log

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Author: surbhigarg92

src/metrics/spanner-metrics-exporter.ts

@@ -31,6 +31,7 @@ export class CloudMonitoringMetricsExporter implements PushMetricExporter {
   private _projectId: string | void | Promise<string | void>;
   private _lastExported: Date = new Date(0);
   private readonly _client: MetricServiceClient;
+  private _metricsExportFailureLogged = false;
 
   constructor({auth}: ExporterOptions) {
     this._client = new MetricServiceClient({auth: auth});
@@ -65,7 +66,6 @@ export class CloudMonitoringMetricsExporter implements PushMetricExporter {
 
     this._lastExported = now;
     this._exportAsync(metrics).then(resultCallback, err => {
-      console.error(err.message);
       resultCallback({code: ExportResultCode.FAILED, error: err});
     });
   }
@@ -104,18 +104,22 @@ export class CloudMonitoringMetricsExporter implements PushMetricExporter {
         async batchedTimeSeries => this._sendTimeSeries(batchedTimeSeries),
       ),
     ).catch(e => {
-      const error = e as {code: number};
-      if (error.code === status.PERMISSION_DENIED) {
-        console.warn(
-          `Need monitoring metric writer permission on project ${this._projectId}. Follow https://cloud.google.com/spanner/docs/view-manage-client-side-metrics#access-client-side-metrics to set up permissions`,
-        );
+      if (!this._metricsExportFailureLogged) {
+        const error = e as {code: number};
+        let msg = 'Send TimeSeries failed:';
+        if (error.code === status.PERMISSION_DENIED) {
+          msg += ` Need monitoring metric writer permission on project ${this._projectId}. Follow https://cloud.google.com/spanner/docs/view-manage-client-side-metrics#access-client-side-metrics to set up permissions`;
+        }
+        console.warn(msg);
+        this._metricsExportFailureLogged = true;
       }
-      const err = asError(e);
-      err.message = `Send TimeSeries failed: ${err.message}`;
-      failure = {sendFailed: true, error: err};
-      console.error(`ERROR: ${err.message}`);
+      failure = {sendFailed: true, error: asError(e)};
     });
 
+    if (!failure.sendFailed && this._metricsExportFailureLogged) {
+      this._metricsExportFailureLogged = false;
+    }
+
     return failure.sendFailed
       ? {
           code: ExportResultCode.FAILED,

test/metrics/spanner-metrics-exporter.ts

@@ -226,10 +226,7 @@ describe('Export', () => {
 
     const callbackResult = resultCallbackSpy.getCall(0).args[0];
     assert.strictEqual(callbackResult.code, ExportResultCode.FAILED);
-    assert.strictEqual(
-      callbackResult.error.message,
-      'Send TimeSeries failed: Network error',
-    );
+    assert.strictEqual(callbackResult.error.message, 'Network error');
 
     assert(sendTimeSeriesStub.calledOnce);
   });