[DOM] Clean up Fragment listeners on signal abort - #37457
Merged
eps1lon merged 4 commits intoSep 1, 2026
Merged
Conversation
|
Comparing: 065bc84...2ff47b7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) Generated by sizebot against 2ff47b7 |
chirokas
force-pushed
the
fragment-refs/events-with-signal-2026-08-30
branch
from
August 30, 2026 09:01
c267804 to
056bc82
Compare
chirokas
marked this pull request as ready for review
August 30, 2026 09:05
Contributor
Author
chirokas
force-pushed
the
fragment-refs/events-with-signal-2026-08-30
branch
from
August 31, 2026 12:23
616d719 to
0f1ed59
Compare
chirokas
force-pushed
the
fragment-refs/events-with-signal-2026-08-30
branch
from
August 31, 2026 15:59
0f1ed59 to
a062186
Compare
chirokas
force-pushed
the
fragment-refs/events-with-signal-2026-08-30
branch
from
September 1, 2026 12:45
a062186 to
2ff47b7
Compare
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #37450
Fixes #37449
Listeners registered with
options.signalare supposed to be removed when the signal is aborted.Since
FragmentInstancedoes not clean up its tracked listeners on abort, previously removed listeners cannot be re-attached.How did you test this change?