Patch parse_params() to deal with BSD strtol() - #129
Closed
peterjeremy wants to merge 1 commit into
Closed
peterjeremy wants to merge 1 commit into
peterjeremy wants to merge 1 commit into
Conversation
performed and FreeBSD (at least) implements thin behaviour. Add an explicit test to detect this situation in Dispatcher::parse_params(). (This behaviour difference is not relevant to other uses of strtol()). This corrects the mishandling of (eg) "CSI m" on FreeBSD.
Contributor
Author
|
This should be linked to #126 but I have no idea how to make github do that. |
Member
|
Thanks for this -- we will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strtol(3) can optionally set errno to EINVAL if no conversion could be
performed and FreeBSD (at least) implements thin behaviour. Add an
explicit test to detect this situation in Dispatcher::parse_params().
(This behaviour difference is not relevant to other uses of strtol()).
This corrects the mishandling of (eg) "CSI m" on FreeBSD.