Only enumerate extension entry points when required#1216
Merged
waylan merged 3 commits intoPython-Markdown:masterfrom May 24, 2022
Merged
Only enumerate extension entry points when required#1216waylan merged 3 commits intoPython-Markdown:masterfrom
waylan merged 3 commits intoPython-Markdown:masterfrom
Conversation
On my machine, this saves 33 milliseconds off import time for the library. ``` (master) $ hyperfine 'python -m markdown' Benchmark 1: python -m markdown Time (mean ± σ): 113.1 ms ± 11.5 ms [User: 84.8 ms, System: 19.2 ms] Range (min … max): 100.1 ms … 151.7 ms 19 runs (late-extensions) $ hyperfine 'python -m markdown' Benchmark 1: python -m markdown Time (mean ± σ): 80.7 ms ± 4.7 ms [User: 61.0 ms, System: 13.1 ms] Range (min … max): 73.9 ms … 94.8 ms 30 runs ```
Member
|
I will merge this if a note is added to the release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my machine, this saves 33 milliseconds off import time for the library, which could be significant for e.g. CLI applications.
There is also a small benefit to the overall test suite run time:
Going forward, one could consider making the
importlib.metadatabackport an optional dependency – it's only required if one wants to load an extension by name.