Skip to content

Fix running example on the web browser.#1

Open
blueorbitz wants to merge 1 commit intobuidler-labs:mainfrom
blueorbitz:bugfix/running-example-on-browser
Open

Fix running example on the web browser.#1
blueorbitz wants to merge 1 commit intobuidler-labs:mainfrom
blueorbitz:bugfix/running-example-on-browser

Conversation

@blueorbitz
Copy link
Copy Markdown

No description provided.

@3Nigma 3Nigma requested review from 3Nigma and victorholo May 4, 2022 08:40
@3Nigma
Copy link
Copy Markdown
Collaborator

3Nigma commented May 4, 2022

Thank you very much for your work and interest, @blueorbitz . We are caught up a bit with other more burning, work-related, stuff but we'll look at your PR as soon as possible. 🙇

@3Nigma
Copy link
Copy Markdown
Collaborator

3Nigma commented May 5, 2022

Didn't know the Provider class changed so drastically in later versions of the @hashgraph/sdk. Thank you for your work in pointing this out, @blueorbitz . We'll have to look into the options more thoroughly. Currently, Strato targets @hashgraph/sdk v2.11.3, I think.

I'll try to take a closer look at your changes during the weekend.

@3Nigma
Copy link
Copy Markdown
Collaborator

3Nigma commented May 7, 2022

@blueorbitz , why are you saying that the repo is not working. If you clone it fresh and do

$ npm install
$ npm run build
$ npm start

you should be able to start serving the demo-app. You must go through the https url to be able to interact with the browser wallet extension.

@blueorbitz
Copy link
Copy Markdown
Author

Anyway, as you suggested I tried doing the same to install a fresh build. This is what I was getting
image

I notice that the Provider is just an empty class, thus I think removing it should be just fine.

This is the second error I notice. It compiled just fine. Manage to prompt the approval from the Hashpack. Then this happens.
image

After fixing the super with super(opts.account.id, opts.account, null); it works for me. I am not too sure about your setup.

Foremostly, I tried to reduce the global dependency on the dev environment. I need to manually install @babel/core and @hashgraph/sdk to run the build. I think in this case, our library version may vary.

Another option you could opt for is to update the package.json with the proper version of the dependency. I think very likely this was the root cause for the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants