Add first draft of blind auctions EIP#1815
Add first draft of blind auctions EIP#1815corollari wants to merge 12 commits intoethereum:masterfrom
Conversation
corollari
force-pushed
the
blind-auction2
branch
from
4970c94 to
744dec5
Compare
|
@corollari can you please rebase this on master so it can be merged (some new checks were introduced)? |
|
sure! |
|
|
||
| ## Motivation | ||
| <!--The motivation is critical for EIPs that want to change the Ethereum protocol. It should clearly explain why the existing protocol specification is inadequate to address the problem that the EIP solves. EIP submissions without sufficient motivation may be rejected outright.--> | ||
| Many dApps that use blind auctions have appeared in the last years, each one reinventing the wheel and implementing blind auctions in ways that are conceptually similar but with special quirks and different interfaces, thus making it impossible for a system to interact with all of these without accommodating all these differences. This ERC aims to solve that by standarizing an interface for blind auctions contracts, which will enable the creation of systems that can interact with any blind auctions without requiring specialized code. |
There was a problem hiding this comment.
Can you add some examples for these "many dapps" (including links to the interfaces they use)?
This can be placed in a section called References or perhaps in Rationale explaining some of the decisions based on those.
There was a problem hiding this comment.
Sure, in an earlier version I used to have a list of other projects using blind auctions but I ended up deleting it because it felt like just having a list didn't really add much value. I'll just restore it
There was a problem hiding this comment.
It can be a good way to show the user base and that may help in engaging with those projects.
There was a problem hiding this comment.
Added a list of some projects that implemented blind auctions (all of them with slight differences). Not sure how many I should list so just left it at 5.
| interface BlindAuction { | ||
| enum Mode { Open, Auction, Owned, Forbidden, Reveal, NotYetAvailable } | ||
|
|
||
| event AuctionStarted(bytes32 indexed hash, uint registrationDate); |
There was a problem hiding this comment.
I think it would be a good idea to comment (perhaps using NatSpec) each of these interfaces as done in other ERCs. See http://eips.ethereum.org/EIPS/eip-721 as an example.
There was a problem hiding this comment.
Will start working on it
|
|
||
| ## Rationale | ||
| <!--The rationale fleshes out the specification by describing what motivated the design and why particular design decisions were made. It should describe alternate designs that were considered and related work, e.g. how the feature is supported in other languages. The rationale may also provide evidence of consensus within the community, and should discuss important objections or concerns raised during discussion.--> | ||
| The interface proposed has been chosen because it is the one used by the Ethereum Name System, which is the most popular project among the ones that use blind auctions, therefore being the one that has the most systems that integrate with it. By picking this interface we aim at minimizing the total amount of work that will be needed to migrate existing systems to the interface proposed, while maximizing the number of systems that will already be compatible with a contract implementing the interface described. |
There was a problem hiding this comment.
If this is an exact copy of what ENS is using, maybe it would be courteous to include the ENS authors in the author field of the ERC?
There was a problem hiding this comment.
I've previously contacted some of them and they didn't seem interested in being authors but I'll try to contact the others.
Edit: If someone else (from the ENS or not) is interested in authoring this EIP along with me please reach out!
|
Thanks for the feedback. |
|
Added another implementation by me that is currently WIP. |
|
I won't be able to work on this PR for the upcoming month. |
|
There has been no activity on this pull request for two months. It will be closed in a week if no further activity occurs. If you would like to move this EIP forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review. |
|
There's some more work I'd like to do on this EIP but given that I haven't had the time to commit to it, I agree that the best way forward is to close it for now. |
2 participants
First draft of an EIP that standardises the interface of blind auction contracts.
Discussion: #1745