Fix Tab completion on Array causes ammonite to exit (#252)#258
Merged
lihaoyi merged 1 commit intocom-lihaoyi:masterfrom Nov 15, 2015
ssanj:master
Merged
Fix Tab completion on Array causes ammonite to exit (#252)#258lihaoyi merged 1 commit intocom-lihaoyi:masterfrom ssanj:master
lihaoyi merged 1 commit intocom-lihaoyi:masterfrom
ssanj:master
Conversation
Added a Try around the awaitResponse method to prevent an Exception killing the Ammonite Repl. The awaitResponse method throws an Exception if a match can't be found for a completion. The Failure case simply returns an empty List[pressy.Member]. This seems like the simplest and least invasive fix for issue #252, although it may not be ideal.
lihaoyi
added a commit
that referenced
this pull request
Nov 15, 2015
Fix Tab completion on Array causes ammonite to exit (#252)
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Try around the awaitResponse method to prevent an Exception
killing the Ammonite Repl. The awaitResponse method throws an Exception
if a match can't be found for a completion.
The Failure case simply returns an empty List[pressy.Member]. This seems
like the simplest and least invasive fix for issue #252, although it may
not be ideal.