Autocomplete import $ivy too #957
Merged
alexarchambault merged 3 commits intocom-lihaoyi:masterfrom May 2, 2019
Merged
Conversation
Collaborator
Author
|
Result: |
alexarchambault
force-pushed
the
tweak-completion
branch
from
c97ca16 to
a76f49c
Compare
when completing multiple imports
alexarchambault
force-pushed
the
tweak-completion
branch
from
a76f49c to
ce6b28d
Compare
alexarchambault
force-pushed
the
tweak-completion
branch
from
ce6b28d to
1169255
Compare
Member
|
lgtm ship it |
tgodzik
pushed a commit
to scalameta/metals
that referenced
this pull request
Sep 14, 2022
Hi, I've been playing around with Ammonite ivy import completions in metals (heavily inspired by com-lihaoyi/Ammonite#957) using the awesome coursier api, demo: It works very similarly to the existing completions for `$file`s, essentially we just ask `coursierapi.Complete` for completions. Additionally, when we're at `import $ivy.|` we return a snippet to handle backticks, and when we're at `group:|` we make sure to get scala verion-specific (e.g. `%%`) completions also (hopefully these are both clear from the video). If you're all happy with this, I'd prefer to work incrementally on the above so as not to make one huge PR 🙂 . Anyway, let me know what you think, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.