Skip to content

feat(framework): add nuxt framework client#10684

Closed
peterbud wants to merge 32 commits intonextauthjs:mainfrom
peterbud:framework-nuxt
Closed

feat(framework): add nuxt framework client#10684
peterbud wants to merge 32 commits intonextauthjs:mainfrom
peterbud:framework-nuxt

Conversation

@peterbud
Copy link
Copy Markdown

@peterbud peterbud commented Apr 22, 2024

☕️ Reasoning

This PR is aiming to add support for Nuxt framework to @AuthJS

🧢 Checklist

  • Add SetEnvDefaults to be consistent with other frameworks
  • Discuss CSRF vs Origin checking approach
  • Documentation
  • Ready to be merged

🎫 Affected issues

N/A

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 2:14pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 2:14pm

@ndom91
Copy link
Copy Markdown
Member

ndom91 commented Apr 22, 2024

Followup Todos for us:

  • Add example repo (nextauthjs/nuxt-example-app)
  • Ensure Balazs github token can write to that (for sync)
  • Double check example code sync to that new repo
  • Add nuxt example app Vercel project (with shared env vars)
  • Add nuxt.authjs.dev subdomain

@orenmizr
Copy link
Copy Markdown

orenmizr commented May 7, 2024

is it possible to build it and use it as alpha until the production version released ? @peterbud

@peterbud
Copy link
Copy Markdown
Author

is it possible to build it and use it as alpha until the production version released ? @peterbud

I think we are pretty early in the process of creating this framework, I'd love to have a proper review from the AuthJS core members before suggesting to use this.

@vercel
Copy link
Copy Markdown

vercel bot commented May 24, 2024

@peterbud is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jun 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@ndom91
Copy link
Copy Markdown
Member

ndom91 commented Nov 3, 2024

Okay gotcha, I'll revert that then. Unfortunately the auto-detect env vars from @auth/core wont work then without additional changes there, but that's okay for now imo

@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/client-dynamodb@3.658.1 Transitive: environment, filesystem, shell +28 3.7 MB aws-sdk-bot
npm/@aws-sdk/lib-dynamodb@3.658.1 None +1 264 kB amzn-oss, aws-sdk-bot, kuhe, ...2 more
npm/@builder.io/qwik-city@1.9.0 eval, network +1 2.59 MB shairez
npm/@builder.io/qwik@1.9.0 eval 0 47.6 MB shairez
npm/@cloudflare/workers-types@4.20240925.0 None 0 4.29 MB wrangler-publisher
npm/@eslint/compat@1.1.1 None 0 47.7 kB eslintbot
npm/@eslint/js@9.11.1 None 0 14.2 kB eslintbot, openjsfoundation
npm/@graphql-codegen/cli@5.0.2 environment, filesystem, network, shell, unsafe +59 15.2 MB dotansimha
npm/@graphql-codegen/client-preset@4.3.3 Transitive: environment, eval, filesystem, shell, unsafe +43 15.7 MB dotansimha
npm/@graphql-typed-document-node/core@3.2.0 None 0 2.96 kB dotansimha
npm/@inkeep/widgets@0.2.289 Transitive: environment, filesystem, network, shell, unsafe +28 22.2 MB sarah-inkeep
npm/@mikro-orm/core@5.9.8 environment, eval, filesystem, unsafe 0 889 kB b4nan
npm/@mikro-orm/sqlite@5.9.8 filesystem +1 354 kB b4nan
npm/@miniflare/d1@2.14.2 filesystem, unsafe Transitive: environment, eval, network, shell +5 460 kB wrangler-publisher
npm/@next/third-parties@14.2.16 None 0 14.2 kB matt.straka, rauchg, timer, ...2 more
npm/@nuxt/kit@3.13.2 None 0 147 kB danielroe
npm/@nuxt/module-builder@0.8.4 None 0 20.3 kB danielroe
npm/@nuxt/schema@3.13.2 None 0 580 kB danielroe
npm/@playwright/test@1.40.0 None 0 25.3 kB dgozman-ms
npm/@preact/preset-vite@2.9.1 Transitive: environment, filesystem, unsafe +37 12 MB marvinhagemeister
npm/@prettier/plugin-pug@3.1.0 environment 0 355 kB shinigami92
npm/@prisma/client@5.20.0 environment, filesystem, shell 0 9.16 MB prismabot
npm/@prisma/extension-accelerate@1.1.0 None 0 62.8 kB prismabot
npm/@radix-ui/react-accordion@1.2.1 None +13 321 kB chancestrickland
npm/@radix-ui/react-tabs@1.1.1 None +13 303 kB chancestrickland
npm/vite@5.4.8 None 0 3.26 MB antfu, patak, soda, ...2 more

🚮 Removed packages: npm/@auth/solid-start@0.13.0, npm/@aws-sdk/client-dynamodb@3.499.0, npm/@aws-sdk/lib-dynamodb@3.499.0, npm/@cloudflare/workers-types@4.20240117.0, npm/@solidjs/meta@0.28.7, npm/@solidjs/router@0.6.0, npm/autoprefixer@10.4.20, npm/postcss@8.4.44, npm/solid-js@1.8.22, npm/solid-start-node@0.2.32, npm/solid-start-vercel@0.2.32, npm/solid-start@0.2.32, npm/tailwindcss@3.4.10, npm/typescript@5.2.2, npm/vite@3.2.10, npm/vite@5.3.1, npm/zod@3.23.8

View full report↗︎

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (a1cf406) to head (227440a).
Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10684       +/-   ##
===========================================
+ Coverage   39.15%   77.17%   +38.02%     
===========================================
  Files         191      114       -77     
  Lines       29988     2936    -27052     
  Branches     1291      385      -906     
===========================================
- Hits        11742     2266     -9476     
+ Misses      18246      670    -17576     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orenmizr
Copy link
Copy Markdown

orenmizr commented Nov 6, 2024

i noticed next-auth changed in v5. will this be v5 compatible ? will this be offical nuxt or community ?

kudos @peterbud for sticking with it all this time.

@peterbud
Copy link
Copy Markdown
Author

i noticed next-auth changed in v5. will this be v5 compatible ?

v5 compatible

@peterbud
Copy link
Copy Markdown
Author

peterbud commented Nov 17, 2024

I'm not sure what else would be needed to move forward with this PR.

It has been open for more than 6 months, and recently I looked optimistic in the future as we finally managed to get the reviews completed with the help of the core team.

In the last 2 weeks this PR seems to be stalled again, and it's again drifting from the main branch.

Could you please answer the question honestly and make a decision on whether there is more effort to be done into this PR (and what that would be), or make the decision to cancel this PR. At this point I think canceling this PR is probably more respectful to each others time and energy.

@gsxdsm
Copy link
Copy Markdown

gsxdsm commented Nov 27, 2024

Would love to see this merged in

@gsxdsm
Copy link
Copy Markdown

gsxdsm commented Nov 27, 2024

@ThangHuuVu can this please be merged? Thanks!

@orenmizr
Copy link
Copy Markdown

orenmizr commented Nov 27, 2024

not sure why "authjs" has been ignoring nuxt. it is the closest the next. in this time, a lot of devs (myself included) turned to nuxt-auth-utils as the alternative. @peterbud i appreciate your efforts regardless of the outcome.

@gsxdsm
Copy link
Copy Markdown

gsxdsm commented Nov 27, 2024

Agree @peterbud thank you so much!

@moshetanzer
Copy link
Copy Markdown

Starting to think that they are waiting approval from next/vercel (jokes aside)!

@peterbud
Copy link
Copy Markdown
Author

peterbud commented Dec 9, 2024

not sure why "authjs" has been ignoring nuxt. it is the closest the next. in this time, a lot of devs (myself included) turned to nuxt-auth-utils as the alternative

I agree. I think I have to let this go.

@peterbud peterbud closed this Dec 9, 2024
@moshetanzer
Copy link
Copy Markdown

@peterbud really appreciate all the effort. Really such a disgrace of the team!

@gsxdsm
Copy link
Copy Markdown

gsxdsm commented Dec 9, 2024

Agree thanks @peterbud ! Based on how this was handled I moved to better-auth. Works superbly.

@zoey-kaiser
Copy link
Copy Markdown

Hi @peterbud 👋

I’ve been following the progress of this PR and was really excited to see where it was heading. You’ve done an amazing job with the integration, and it’s honestly a bit sad to see the PR closed.

I work on a Nuxt 3 module for NextAuth called @sidebase/nuxt-auth, and we’ve tried several times to update it to work with AuthJS. Unfortunately, we've run into some stability issues along the way.

Seeing how much progress you’ve made, I wanted to reach out and see if you'd be interested in helping us tackle some of the issues we’ve faced with the upgrade. It would be awesome to release a Nuxt 3 integration of AuthJS for the community!

If you're interested, feel free to DM me on BlueSky: https://bsky.app/profile/zoeykaiser.com

@peterbud
Copy link
Copy Markdown
Author

Hi @zoey-kaiser,

Thank you so much for your kind words and for following the progress of the PR. I truly appreciate your support and enthusiasm.

I understand the challenges you've faced with updating your Nuxt 3 module to work with AuthJS. However, at this time, I must politely decline your request for assistance. The future of AuthJS seems uncertain, and the maintainers appear to be somewhat disconnected, which makes it difficult to commit to this integration.

I wish you the best of luck with your project and hope you find a suitable solution soon.

@AdnanCukur
Copy link
Copy Markdown

This is critical for our use case. We’d love to see this merged please let us know if we can help with testing or resolving any blockers!

@moshetanzer
Copy link
Copy Markdown

@AdnanCukur don't waste your time. The team were rude and unhelpful tk @peterbud who put in the effort. This has fallen way behind. Rather use something like better auth

@makkalay
Copy link
Copy Markdown

that work nice with some tweaks, https://authjs-nuxt.pages.dev/getting-started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.