Skip to content

inspector: add Network.Initiator in inspector protocol#56805

Closed
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:inspector/network-initiator
Closed

inspector: add Network.Initiator in inspector protocol#56805
legendecas wants to merge 2 commits intonodejs:mainfrom
legendecas:inspector/network-initiator

Conversation

@legendecas
Copy link
Copy Markdown
Member

@legendecas legendecas commented Jan 28, 2025

src: add a hard dependency v8_inspector_headers

A GYP hard dependency instructs GYP to not remove the dependency link
between two static library targets in its generated output. This
allows V8 dependents to include V8 inspector protocol headers.

inspector: add Network.Initiator in inspector protocol

Add initiator stack trace in inspector network events, reflecting
the location where the script created the request.

The http.client.request.created event is closer to where user code
creates the http request, and correctly reflects which script
initiated the request.

Refs: #53946

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants