docs: fix typo#4081
Merged
wraithgar merged 1 commit intonpm:release-nextfrom Nov 22, 2021
idleberg:patch-1
Merged
Conversation
wraithgar
approved these changes
Nov 22, 2021
PR-URL: #4081 Credit: @idleberg Close: #4081 Reviewed-by: @wraithgar
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has previously been made in the documentation repository. @MylesBorins left the following comment before closing that PR.
I think the intention for the fix has been misunderstood. I'm assuming that the documentation runs through some kind of build process, where the Markdown files are converted to HTML. However, this PR does not try to change any of those links, but the text used on that link.
See this screenshot of the affected paragraph:
Elsewhere on the same page, the same link is used but with a different text. Here's another screenshot of that paragraph:
This text makes more sense and matches the title of the linked document, so the same should be applied to the other occurence of the link – this PR does just that.