Improved checked_isqrt and isqrt methods#128166
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 29, 2024
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved tests of
isqrtandchecked_isqrtimplementationsisqrtandchecked_isqrthave equivalent results for signed types, either equivalent numerically or equivalent as a panic and aNone.isqrthas numerically-equivalent results for unsigned types and theirNonZerocounterparts.Added benchmarks for
isqrtimplementationsGreatly sped up
checked_isqrtandisqrtmethodsFeature tracking issue
isqrtis an unstable feature tracked at #116226.Benchmarked improvements
Command used to benchmark
Before
After
Tracking Issue for {u8,i8,...}::isqrt #116226
try-job: test-various