Make the dangerous_implicit_autorefs lint deny-by-default#141661
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 8, 2025
Merged
Make the dangerous_implicit_autorefs lint deny-by-default#141661bors merged 1 commit intorust-lang:masterfrom
dangerous_implicit_autorefs lint deny-by-default#141661bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I intended for the
dangerous_implicit_autorefslint to be deny-by-default, the T-lang nomination comment even clearly mentioned deny-by-default, but somehow I and other missed that it is only warn-by-default.I think the lint should still be deny-by-default as the implicit aliasing requirements can be quite dangerous.
In any-case, opening this PR for T-lang awareness.
@rustbot label +I-lang-nominated +T-lang
r? @traviscross