unsafe_binder: implement v0 symbol mangling#154524
Open
GrigorenkoPV wants to merge 1 commit intorust-lang:mainfrom
Open
unsafe_binder: implement v0 symbol mangling#154524GrigorenkoPV wants to merge 1 commit intorust-lang:mainfrom
unsafe_binder: implement v0 symbol mangling#154524GrigorenkoPV wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
056837f to
1173efa
Compare
Member
|
I'm not familiar with the process for modifying the mangling spec, but I'd guess this requires some kind of agreement from the Compiler team Maintainers (not just the members) and rustc book update. Hopefully we get lucky on reroll, otherwise I'll ask on Zulip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #130516
Fixes #154367
rustc_demanglealso needs to be changed, but they are in a separate repo. I think I will put up a PR there once the suggested mangling is deemed OK.