Move $$crate into its own feature gate#155107
Open
nik-rev wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
$$crate into its own feature gate, feature(macro_metavar_expr_dollar_dollar_crate)$$crate into its own feature gate
This comment has been minimized.
This comment has been minimized.
Co-authored-by: c410-f3r <c410-f3r@users.noreply.github.com> uwu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to stabilize
$$meta-variable expression escapes.$$crateis the only blocker, and we're not 100% sure how to handle it, so it should be stabilized separately.I am therefore creating a new incomplete feature gate
macro_metavar_expr_dollar_dollar_cratewhich prevents people from using$$crate, and sending a stabilization PR for$$after this one gets merged.Tracking Issue: #155111
History:
$$was attempted in: Stabilize$$in Rust 1.63.0 #95860.$$crate:$$crateunexpectedly fails to defer which crate$craterefers to #99035$$crate: Forbid$$crate#99193$$crate#99193 (comment)cc @rust-lang/lang (Responsible team)
cc @petrochenkov (Reviewed most of the implementation)
cc @CAD97 (Created the issue)
cc @c410-f3r (Author of the original stabilization PR back in 1.63, and the forbid-
$$cratePR)cc @Mark-Simulacrum (Nominated the issue)