Skip to content

Move $$crate into its own feature gate#155107

Open
nik-rev wants to merge 1 commit intorust-lang:mainfrom
nik-contrib:$$crate
Open

Move $$crate into its own feature gate#155107
nik-rev wants to merge 1 commit intorust-lang:mainfrom
nik-contrib:$$crate

Conversation

@nik-rev
Copy link
Copy Markdown
Contributor

@nik-rev nik-rev commented Apr 10, 2026

I'd like to stabilize $$ meta-variable expression escapes.

$$crate is the only blocker, and we're not 100% sure how to handle it, so it should be stabilized separately.

I am therefore creating a new incomplete feature gate macro_metavar_expr_dollar_dollar_crate which prevents people from using $$crate, and sending a stabilization PR for $$ after this one gets merged.

Tracking Issue: #155111

History:

cc @rust-lang/lang (Responsible team)
cc @petrochenkov (Reviewed most of the implementation)
cc @CAD97 (Created the issue)
cc @c410-f3r (Author of the original stabilization PR back in 1.63, and the forbid-$$crate PR)
cc @Mark-Simulacrum (Nominated the issue)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 10, 2026

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

@nik-rev nik-rev mentioned this pull request Apr 10, 2026
2 tasks
@nik-rev nik-rev changed the title Move $$crate into its own feature gate, feature(macro_metavar_expr_dollar_dollar_crate) Move $$crate into its own feature gate Apr 10, 2026
@rust-log-analyzer

This comment has been minimized.

Co-authored-by: c410-f3r <c410-f3r@users.noreply.github.com>

uwu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants