Better docs for the str primitive#30057
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 1, 2015
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
force-pushed
the
doc_str
branch
from
0c13e4b to
a4ee9f5
Compare
src/libcollections/str.rs
Outdated
Contributor
There was a problem hiding this comment.
I think the comma after chars is potentially confusing.
steveklabnik
force-pushed
the
doc_str
branch
from
a4ee9f5 to
a4142e9
Compare
src/libcollections/str.rs
Outdated
Member
There was a problem hiding this comment.
I usually call these things “preconditions”. Is there any pretext to use “sets of bounds” instead of “preconditions” or “requirements” or another familiar synonym?
Contributor
Author
There was a problem hiding this comment.
There isn't, actually. It would be good to check what we use elsewhere, hmmm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #29338