Remove impl Foo for .. {} in favor auto trait Foo {}#46480
Closed
leoyvens wants to merge 8 commits intorust-lang:masterfrom
Closed
Remove impl Foo for .. {} in favor auto trait Foo {}#46480leoyvens wants to merge 8 commits intorust-lang:masterfrom
impl Foo for .. {} in favor auto trait Foo {}#46480leoyvens wants to merge 8 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new syntax was introduced and the old one deprecated in #45247. This removes the old syntax and simplifies some code as a result. Some errors that were possible with the old syntax no longer make sense. WF checking is moved to an ast validation.
There is some conflict with #46455, nothing serious. I guess this PR should be preferred where there is a conflict.