Refactor ppaux out of existence.#58140
Merged
bors merged 70 commits intorust-lang:masterfrom Mar 15, 2019
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long-time coming, this PR reorganizes and rewrites the pretty-printing architecture of rustc, specifically the parts that involve the typesystem (which used to be in
rustc::util::ppaux).Note: these commits used to be in #57967 before being split off.
The new API (i.e. the
PrinterandPrettyPrinttraits) is inrustc::ty::print.Design points, roughly:
Printerto allow building e.g. an AST, not just printing as a side-effectPrettyPrinter, e.g. how<...>is printedfmt::Displayimpls, the value to print is lifted to thety::tlstcx, and everything after that stays within thety::printAPI, which requires'tcxto match between values and the printer'stcx, without going throughfmt::DisplayagainMost of the behavior is unchanged, except for a few details, which should be clear from the test changes.
r? @nikomatsakis
Fixes #55464