Fix memory pre-allocation for multibyte separators#8
Open
szabgab wants to merge 1 commit intotov:masterfrom
Open
Fix memory pre-allocation for multibyte separators#8szabgab wants to merge 1 commit intotov:masterfrom
szabgab wants to merge 1 commit intotov:masterfrom
Conversation
The statement changed tried to allocate enough space for the original string + 1 byte for each separator. This is not enough when the separator itself is multibyte (e.g. an emoji) The smilies test-case uses 2 emojies as separators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The statement changed tried to allocate enough space for the original string + 1 byte for each separator. This is not enough when the separator itself is multibyte (e.g. an emoji)
The smilies test-case uses 2 emojies as separators.
See #7