tail: disallow clippy::wrong_self_convention

Author: oech3

src/uu/tail/src/follow/watch.rs

@@ -482,7 +482,7 @@ pub fn follow(mut observer: Observer, settings: &Settings) -> UResult<()> {
         return Err(USimpleError::new(1, translate!("tail-no-files-remaining")));
     }
 
-    let mut process = platform::ProcessChecker::new(observer.pid);
+    let process = platform::ProcessChecker::new(observer.pid);
 
     let mut timeout_counter = 0;
 

src/uu/tail/src/platform/unix.rs

@@ -19,9 +19,7 @@ impl ProcessChecker {
         Self { pid: process_id }
     }
 
-    // Borrowing mutably to be aligned with Windows implementation
-    #[allow(clippy::wrong_self_convention)]
-    pub fn is_dead(&mut self) -> bool {
+    pub fn is_dead(&self) -> bool {
         unsafe { libc::kill(self.pid, 0) != 0 && get_errno() != libc::EPERM }
     }
 }

src/uu/tail/src/platform/windows.rs

@@ -3,6 +3,7 @@
 // For the full copyright and license information, please view the LICENSE
 // file that was distributed with this source code.
 
+use std::cell::Cell;
 use windows_sys::Win32::Foundation::{CloseHandle, HANDLE, WAIT_FAILED, WAIT_OBJECT_0};
 use windows_sys::Win32::System::Threading::{
     OpenProcess, PROCESS_SYNCHRONIZE, WaitForSingleObject,
@@ -12,7 +13,7 @@ use windows_sys::core::BOOL;
 pub type Pid = u32;
 
 pub struct ProcessChecker {
-    dead: bool,
+    dead: Cell<bool>,
     handle: HANDLE,
 }
 
@@ -22,21 +23,20 @@ impl ProcessChecker {
         let FALSE: BOOL = 0;
         let h = unsafe { OpenProcess(PROCESS_SYNCHRONIZE, FALSE, process_id) };
         Self {
-            dead: h.is_null(),
+            dead: Cell::new(h.is_null()),
             handle: h,
         }
     }
 
-    #[allow(clippy::wrong_self_convention)]
-    pub fn is_dead(&mut self) -> bool {
-        if !self.dead {
-            self.dead = unsafe {
+    pub fn is_dead(&self) -> bool {
+        if !self.dead.get() {
+            self.dead.set(unsafe {
                 let status = WaitForSingleObject(self.handle, 0);
                 status == WAIT_OBJECT_0 || status == WAIT_FAILED
-            }
+            });
         }
 
-        self.dead
+        self.dead.get()
     }
 }