sort: fix extended test_sort::test_buffer_sizes failures#11078
sort: fix extended test_sort::test_buffer_sizes failures#11078xtqqczze wants to merge 4 commits intouutils:mainfrom
Conversation
Merging this PR will degrade performance by 11.61%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | sort_ascii_utf8_locale |
15.8 ms | 17.7 ms | -10.93% |
| ⚡ | Simulation | sort_long_line[10000] |
514.7 µs | 432.1 µs | +19.12% |
| ❌ | Simulation | sort_ascii_c_locale |
16 ms | 17.5 ms | -8.7% |
| ❌ | Memory | sort_ascii_utf8_locale |
4.6 MB | 5.2 MB | -10.75% |
| ❌ | Memory | sort_numeric[500000] |
43.4 MB | 45.2 MB | -3.99% |
| ❌ | Memory | sort_mixed_data[500000] |
20.5 MB | 22.3 MB | -8.1% |
| ❌ | Memory | sort_general_numeric[200000] |
22.8 MB | 23.8 MB | -3.91% |
| ❌ | Memory | sort_mixed_utf8_locale |
2.3 MB | 2.6 MB | -11.61% |
| ⚡ | Memory | sort_long_line[10000] |
139 KB | 58.8 KB | ×2.4 |
| ⚡ | Memory | sort_german_c_locale |
1.8 MB | 1.7 MB | +4.04% |
| ❌ | Memory | sort_dictionary_order[500000] |
20.6 MB | 22.4 MB | -8.07% |
| ❌ | Memory | sort_unique_locale[500000] |
32 MB | 33.4 MB | -4.28% |
| ❌ | Memory | sort_accented_data[500000] |
20.5 MB | 21.9 MB | -6.52% |
| ❌ | Memory | sort_ascii_only[500000] |
20.5 MB | 22 MB | -6.79% |
| ❌ | Memory | sort_reverse_locale[500000] |
20.5 MB | 21.9 MB | -6.52% |
| ❌ | Memory | sort_key_field[500000] |
28.1 MB | 29.3 MB | -4.02% |
| ❌ | Memory | sort_mixed_c_locale |
2.3 MB | 2.6 MB | -11.61% |
| ⚡ | Memory | sort_german_de_locale |
1.8 MB | 1.7 MB | +4.04% |
| ❌ | Memory | sort_unique_utf8_locale |
3.5 MB | 3.8 MB | -8.08% |
| ❌ | Memory | sort_reverse_utf8_locale |
2.3 MB | 2.6 MB | -11.61% |
| ... | ... | ... | ... | ... | ... |
ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.
Comparing xtqqczze:sort-alloc-size (5e269ff) with main (79fc0c7)
Footnotes
-
42 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
52849ca to
514f9ce
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
d4df783 to
42b3819
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
@sylvestre please review so we can get into |
|
Do you really wan to merge this with current size? There are 2 Simulation perf regression. |
|
The main priority is to fix the test failures observed in #11081 |
|
Are big fixtures new test cases we were lacking? |
Fixes the test failures observed in #11081 by reverting 4438adf and b61a38e