changeset:   106230:e371686229e7
user:        Victor Stinner <victor.stinner@gmail.com>
date:        Thu Jan 19 12:45:06 2017 +0100
files:       Objects/dictobject.c
description:
Add a note explaining why dict_update() doesn't use METH_FASTCALL

Issue #29312.


diff -r 00c63ee66e0c -r e371686229e7 Objects/dictobject.c
--- a/Objects/dictobject.c	Thu Jan 19 12:37:13 2017 +0100
+++ b/Objects/dictobject.c	Thu Jan 19 12:45:06 2017 +0100
@@ -2347,6 +2347,9 @@
     return result;
 }
 
+/* Note: dict.update() uses the METH_VARARGS|METH_KEYWORDS calling convention.
+   Using METH_FASTCALL would make dict.update(**dict2) calls slower, see the
+   issue #29312. */
 static PyObject *
 dict_update(PyObject *self, PyObject *args, PyObject *kwds)
 {