bpo-35194: Fix a wrong constant in cp932 codec (GH-10420)

miss-islington · Alexey Izbyshev · web-flow · commit 49ee41f1c393 · 2018-11-08T23:33:10.000-08:00
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation. https://bugs.python.org/issue35194 (cherry picked from commit 7a69cf4) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
diff --git a/Modules/cjkcodecs/_codecs_jp.c b/Modules/cjkcodecs/_codecs_jp.c
@@ -40,7 +40,7 @@ ENCODER(cp932)
             if (c == 0xf8f0)
                 OUTBYTE1(0xa0);
             else
-                OUTBYTE1(c - 0xfef1 + 0xfd);
+                OUTBYTE1(c - 0xf8f1 + 0xfd);
             NEXT(1, 1);
             continue;
         }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ ENCODER(cp932)`
`40`	`40`	`if (c == 0xf8f0)`
`41`	`41`	`OUTBYTE1(0xa0);`
`42`	`42`	`else`
`43`		`- OUTBYTE1(c - 0xfef1 + 0xfd);`
	`43`	`+ OUTBYTE1(c - 0xf8f1 + 0xfd);`
`44`	`44`	`NEXT(1, 1);`
`45`	`45`	`continue;`
`46`	`46`	`}`