Page MenuHomePhabricator
Differential D71740

Bug 1631721 - Vendor the hashbrown crate
ClosedPublic
Actions

Authored by • SimonSapin on Apr 21 2020, 11:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 1, 2:29 AM
Unknown Object (File)
Thu, Mar 26, 9:03 PM
Unknown Object (File)
Mar 14 2026, 8:35 PM
Unknown Object (File)
Mar 14 2026, 8:35 PM
Unknown Object (File)
Mar 10 2026, 12:28 AM
Unknown Object (File)
Mar 9 2026, 2:26 PM
Unknown Object (File)
Feb 13 2026, 11:09 AM
Unknown Object (File)
Feb 9 2026, 1:59 PM
View All 17 Files
Subscribers
emilio

Details

Reviewers
manishearth
Commits
rMOZILLACENTRAL06dcf8ddbfde: Bug 1631721 - Vendor the hashbrown crate r=manishearth
Bugzilla Bug ID
1631721
Summary

This is the hash map implementation now used in the Rust standard library:

Diff Detail

Event Timeline

• SimonSapin created this revision.Apr 21 2020, 11:37 AM
Herald added a project: secure-revision. · View Herald TranscriptApr 21 2020, 11:37 AM
Harbormaster completed remote builds in B186164: Diff 263897.Apr 21 2020, 11:37 AM
• SimonSapin added a child revision: D71741: Bug 1631721 - Use hashbrown instead of hashglobe.Apr 21 2020, 11:37 AM
phab-bot requested review of this revision.Apr 21 2020, 11:37 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: emilio. · View Herald TranscriptApr 21 2020, 11:37 AM
• SimonSapin added a reviewer: manishearth.Apr 22 2020, 3:11 PM
manishearth accepted this revision.Apr 22 2020, 3:16 PM

Hashbrown is already used in rustc so there's no need to carefully review the dependencies ; we use this code already via rustc.

This revision is now accepted and ready to land.Apr 22 2020, 3:16 PM
Closed by commit rMOZILLACENTRAL06dcf8ddbfde: Bug 1631721 - Vendor the hashbrown crate r=manishearth (authored by • SimonSapin). · Explain WhyApr 23 2020, 12:18 PM
This revision was automatically updated to reflect the committed changes.
• SimonSapin added a commit: rMOZILLACENTRAL06dcf8ddbfde: Bug 1631721 - Vendor the hashbrown crate r=manishearth.

Revision Contents
Changeset List

PathSize
servo/
components/
style/
1 line
third_party/
rust/
ahash/
1 line
90 lines
201 lines
25 lines
219 lines
1 line
src/
241 lines
174 lines
222 lines
15 lines
177 lines
322 lines
267 lines
132 lines
104 lines
tests/
226 lines
202 lines
25 lines
autocfg-0.1.6/
autocfg/
src/
autocfg-0.1.6/
201 lines
25 lines
examples/
9 lines
22 lines
26 lines
9 lines
src/
69 lines
60 lines
autocfg/
2 lines
4 lines
20 lines
src/
88 lines
60 lines
tests/
19 lines
const-random-macro/
1 line
201 lines
25 lines
src/
33 lines
const-random-macro/
autocfg/
26 lines
const-random/
1 line
201 lines
25 lines
17 lines
src/
16 lines
tests/
29 lines
const-random/
autocfg/
22 lines
hashbrown/
1 line
208 lines
83 lines
201 lines
25 lines
125 lines
benches/
260 lines
9 lines
1 line
src/
external_trait_impls/
4 lines
rayon/
26 lines
676 lines
4 lines
193 lines
646 lines
200 lines
121 lines
54 lines
3861 lines
raw/
108 lines
155 lines
1528 lines
143 lines
621 lines
49 lines
1906 lines
tests/
65 lines
533 lines
65 lines
30 lines

Diff 265547

View Options

Cargo.lock

Loading...
View Options

servo/components/style/Cargo.toml

Loading...
View Options

third_party/rust/ahash/.cargo-checksum.json

Loading...
View Options

third_party/rust/ahash/Cargo.toml

Loading...
View Options

third_party/rust/ahash/LICENSE-APACHE

Loading...
View Options

third_party/rust/ahash/LICENSE-MIT

Loading...
View Options

third_party/rust/ahash/README.md

Loading...
View Options

third_party/rust/ahash/rustfmt.toml

Loading...
View Options

third_party/rust/ahash/src/aes_hash.rs

Loading...
View Options

third_party/rust/ahash/src/convert.rs

Loading...
View Options

third_party/rust/ahash/src/fallback_hash.rs

Loading...
View Options

third_party/rust/ahash/src/folded_multiply.rs

Loading...
View Options

third_party/rust/ahash/src/hash_map.rs

Loading...
View Options

third_party/rust/ahash/src/hash_quality_test.rs

Loading...
View Options

third_party/rust/ahash/src/hash_set.rs

Loading...
View Options

third_party/rust/ahash/src/lib.rs

Loading...
View Options

third_party/rust/ahash/src/random_state.rs

Loading...
View Options

third_party/rust/ahash/tests/bench.rs

Loading...
View Options

third_party/rust/ahash/tests/map_tests.rs

Loading...
View Options

third_party/rust/ahash/tests/nopanic.rs

Loading...
View Options

third_party/rust/autocfg-0.1.6/.cargo-checksum.json

Loading...
View Options

third_party/rust/autocfg-0.1.6/Cargo.lock

Loading...
View Options

third_party/rust/autocfg-0.1.6/Cargo.toml

Loading...
View Options

third_party/rust/autocfg-0.1.6/LICENSE-APACHE

Loading...
View Options

third_party/rust/autocfg-0.1.6/LICENSE-MIT

Loading...
View Options

third_party/rust/autocfg-0.1.6/README.md

Loading...
View Options

third_party/rust/autocfg-0.1.6/examples/integers.rs

Loading...
View Options

third_party/rust/autocfg-0.1.6/examples/paths.rs

Loading...
View Options

third_party/rust/autocfg-0.1.6/examples/traits.rs

Loading...
View Options

third_party/rust/autocfg-0.1.6/examples/versions.rs

Loading...
View Options

third_party/rust/autocfg-0.1.6/src/error.rs

Loading...
View Options

third_party/rust/autocfg-0.1.6/src/lib.rs

Loading...
View Options

third_party/rust/autocfg-0.1.6/src/tests.rs

Loading...
View Options

third_party/rust/autocfg-0.1.6/src/version.rs

Loading...
View Options

third_party/rust/autocfg/.cargo-checksum.json

Loading...
View Options

third_party/rust/autocfg/Cargo.lock

Loading...
View Options

third_party/rust/autocfg/Cargo.toml

Loading...
View Options

third_party/rust/autocfg/README.md

Loading...
View Options

third_party/rust/autocfg/src/lib.rs

Loading...
View Options

third_party/rust/autocfg/src/tests.rs

Loading...
View Options

third_party/rust/autocfg/tests/rustflags.rs

Loading...
View Options

third_party/rust/const-random-macro/.cargo-checksum.json

Loading...
View Options

third_party/rust/const-random-macro/Cargo.toml

Loading...
View Options

third_party/rust/const-random-macro/LICENSE-APACHE

Loading...
View Options

third_party/rust/const-random-macro/LICENSE-MIT

Loading...
View Options

third_party/rust/const-random-macro/src/lib.rs

Loading...
View Options

third_party/rust/const-random/.cargo-checksum.json

Loading...
View Options

third_party/rust/const-random/Cargo.toml

Loading...
View Options

third_party/rust/const-random/LICENSE-APACHE

Loading...
View Options

third_party/rust/const-random/LICENSE-MIT

Loading...
View Options

third_party/rust/const-random/README.md

Loading...
View Options

third_party/rust/const-random/src/lib.rs

Loading...
View Options

third_party/rust/const-random/tests/tests.rs

Loading...
View Options

third_party/rust/hashbrown/.cargo-checksum.json

Loading...
View Options

third_party/rust/hashbrown/CHANGELOG.md

Loading...
View Options

third_party/rust/hashbrown/Cargo.toml

Loading...
View Options

third_party/rust/hashbrown/LICENSE-APACHE

Loading...
View Options

third_party/rust/hashbrown/LICENSE-MIT

Loading...
View Options

third_party/rust/hashbrown/README.md

Loading...
View Options

third_party/rust/hashbrown/benches/bench.rs

Loading...
View Options

third_party/rust/hashbrown/build.rs

Loading...
View Options

third_party/rust/hashbrown/clippy.toml

Loading...
View Options

third_party/rust/hashbrown/src/external_trait_impls/mod.rs

Loading...
View Options

third_party/rust/hashbrown/src/external_trait_impls/rayon/helpers.rs

Loading...
View Options

third_party/rust/hashbrown/src/external_trait_impls/rayon/map.rs

Loading...
View Options

third_party/rust/hashbrown/src/external_trait_impls/rayon/mod.rs

Loading...
View Options

third_party/rust/hashbrown/src/external_trait_impls/rayon/raw.rs

Loading...
View Options

third_party/rust/hashbrown/src/external_trait_impls/rayon/set.rs

Loading...
View Options

third_party/rust/hashbrown/src/external_trait_impls/serde.rs

Loading...
View Options

third_party/rust/hashbrown/src/lib.rs

Loading...
View Options

third_party/rust/hashbrown/src/macros.rs

Loading...
View Options

third_party/rust/hashbrown/src/map.rs

Loading...
View Options

third_party/rust/hashbrown/src/raw/bitmask.rs

Loading...
View Options

third_party/rust/hashbrown/src/raw/generic.rs

Loading...
View Options

third_party/rust/hashbrown/src/raw/mod.rs

Loading...
View Options

third_party/rust/hashbrown/src/raw/sse2.rs

Loading...
View Options

third_party/rust/hashbrown/src/rustc_entry.rs

Loading...
View Options

third_party/rust/hashbrown/src/scopeguard.rs

Loading...
View Options

third_party/rust/hashbrown/src/set.rs

Loading...
View Options

third_party/rust/hashbrown/tests/hasher.rs

Loading...
View Options

third_party/rust/hashbrown/tests/rayon.rs

Loading...
View Options

third_party/rust/hashbrown/tests/serde.rs

Loading...
View Options

third_party/rust/hashbrown/tests/set.rs

Loading...
Privacy · Cookies · Legal