Add from_timestamp_secs method to DateTime#1719
Merged
djc merged 1 commit intochronotope:mainfrom Aug 14, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
+ Coverage 90.78% 90.79% +0.01%
==========================================
Files 39 39
Lines 16231 16254 +23
==========================================
+ Hits 14735 14758 +23
Misses 1496 1496 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonaowen
commented
Aug 9, 2025
81744ea to
69b1f24
Compare
Contributor
Author
|
I slimmed down the tests, refactored the existing code to use |
Member
Please squash your commits into a single one. |
Add a new single-argument function for creating a `DateTime` from a Unix timestamp, to match `from_timestamp_micros`, `from_timestamp_millis`, and `from_timestamp_nanos`. Refactor existing code and examples to use `DateTime::from_timestamp_secs` and `DateTime::from_timestamp_millis` where possible. Issue chronotope#1716 Suggestion: add DateTime::from_timestamp_secs function
69b1f24 to
fd92d74
Compare
Contributor
Author
|
Relocated and squashed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new single-argument function for creating a
DateTimefrom a Unix timestamp, to matchfrom_timestamp_micros,from_timestamp_millis, andfrom_timestamp_nanos.Resolves #1716 Suggestion: add DateTime::from_timestamp_secs function